Skip to content

Conversation

mattrossman
Copy link
Contributor

  • Pins latest Node LTS in .nvmrc
  • Pins latest pnpm in package.json "packageManagers"
  • Migrates npm workspaces and commands to pnpm
  • Dependencies with the monorepo (e.g. mcp-server-supabase > mcp-utils) are specified with workspace protocol
  • Adds "test:run" script(s) to run tests
  • Updates integration test to create stdio server from local .js build

Copy link
Collaborator

@gregnr gregnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the below question

"dependencies": {
"@modelcontextprotocol/sdk": "^1.11.0",
"@supabase/mcp-utils": "^0.2.1",
"@supabase/mcp-utils": "workspace:*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work when publishing/packing? Will pnpm replace with the current version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pnpm replaces workspace: dependencies with the corresponding version from the workspace. There's some examples of how this behaves at https://pnpm.io/workspaces#publishing-workspace-packages

workspace:* gets replaced with an exact version, but since we currently use ^ for the version range I'll push a change to use workspace:^ to align with existing behavior.

@mattrossman mattrossman merged commit e305905 into main Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants