refactor: more explicit tests #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnr
commented
Apr 7, 2025
| test: { | ||
| include: ['src/**/*.{test,spec}.ts'], | ||
| testTimeout: 20_000, // PGlite can take a while to initialize | ||
| testTimeout: 30_000, // PGlite can take a while to initialize |
There was a problem hiding this comment.
Had a few tests that failed due to timeout that fixed upon re-run. Bumping this to 30s.
olirice
approved these changes
Apr 7, 2025
GQAdonis
pushed a commit
to skytok-net/supabase-mcp
that referenced
this pull request
Aug 14, 2025
…ctor/more-explicit-tests refactor: more explicit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes global mock orgs and projects and instead moves them to each test. This is slightly more verbose but makes testing much clearer and less error prone since each test is responsible for adding mock orgs & projects in the exact states they require prior to performing the test.
For example, we have a bunch of tests that make sure the cost confirmation logic works correctly depending on what payment plan the org is in. It's a lot clearer to define these mock orgs on a per-test basis than globally.