Skip to content

Conversation

muellmusik
Copy link
Contributor

Adjustments ported from new PD code for VBAP 1.0.3.2. LS amounts allocated dynamically.

Adjustments ported from new PD code. LS amounts allocated dynamically.

VBAP 1.0.3.2 Remove ls hardcoded limit
@dyfer
Copy link
Member

dyfer commented Jul 2, 2024

Thanks @muellmusik
Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)

@dyfer
Copy link
Member

dyfer commented Mar 24, 2025

@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?

@muellmusik
Copy link
Contributor Author

Sorry @dyfer, I somehow didn't see these.

Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)

Could you be more specific as to what you want me to do? The code is mostly from old PD code and is a big mix of tabs and spaces. I can change line 288 and 290 to be one or the other if that's what you mean, but it won't make things consistent so I'm not sure what's best. Also which formatting would you like changed?

@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?

I'm okay with that personally. It's a little awkward at the moment as I changed machines and haven't managed to set up a build chain yet (Apple dev license woes...) but I can make changes if need. My personal view is that strict standards for formatting have been dispiriting for some new contributors, and thus aren't really worth it, though I know others have differing views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for review response
Development

Successfully merging this pull request may close these issues.

3 participants