-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add remote function query.stream
#14292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dummdidumm
wants to merge
36
commits into
main
Choose a base branch
from
query-stream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
1affeca
feat: add new remote function `query.batch`
dummdidumm b70a394
my god this high already
dummdidumm bd0c519
hhnngghhhh
dummdidumm 60fb389
feat: add remote function `query.stream`
dummdidumm 41fad93
make it treeshakeable on the client
dummdidumm 4819f97
hydrate data
dummdidumm a955c16
validation
dummdidumm 1b5f453
lint
dummdidumm 5da377d
explain + simplify (no use in clearing a timeout for the next macrotask)
dummdidumm e036a27
fast-path for remote client calls
dummdidumm afdae97
validate
dummdidumm 6434cf3
note in docs about output shape
dummdidumm 5ed076e
Merge branch 'query-batch' into query-stream
dummdidumm 3b54a4c
make it treeshakeable
dummdidumm 96ea81c
oops
dummdidumm 9656a7f
regenerate types
dummdidumm 6665ed6
thanks for nothing service workers
dummdidumm 28a3564
tweak readablestream implementation
dummdidumm 531225c
fix
dummdidumm e630de7
adjust API
dummdidumm cbfa1cf
deduplicate
dummdidumm aa7cd56
test deduplication
dummdidumm 910125c
fix
dummdidumm 476ce72
Merge branch 'query-batch' into query-stream
dummdidumm 2ca6eb1
oops
dummdidumm 3447d75
Merge branch 'query-batch' into query-stream
dummdidumm dfa4cb4
omg lol
dummdidumm d51c20c
Merge branch 'query-batch' into query-stream
dummdidumm 44f60b8
Update documentation/docs/20-core-concepts/60-remote-functions.md
dummdidumm d8d02bc
per-item error handling
dummdidumm 40de6f1
Merge branch 'query-batch' into query-stream
dummdidumm a649cf0
don't share stream()
dummdidumm ac02bc1
Update documentation/docs/20-core-concepts/60-remote-functions.md
dummdidumm 74d0587
Merge branch 'main' into query-stream
dummdidumm 7254df5
Merge branch 'main' into query-stream
Rich-Harris cead45e
remove duplicated docs
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': minor | ||
--- | ||
|
||
feat: add new remote function `query.batch` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': minor | ||
--- | ||
|
||
feat: add remote function `query.stream` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadableStream
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream - the comment is meant as "these are not two network requests, it's one because they share the same stream instance"
I guess I could've written that instead ... 😅