-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: allow commands from within endpoints #14343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4b4de69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d1be925
to
45e6ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is quite right — surely we want to allow commands in POST
requests etc, but not in GET
/HEAD
?
Are you suggesting that SvelteKit should not let developers use certain remote functions inside certain endpoints because of opinions? |
For what technical reason? |
RFC 9110 on HTTP semantics says this:
|
So no technical reason but spec reason. I'm fine looking into adjusting this, just wanted to clarify |
implemented endpoint method check for commands
fixes #14325
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.