Skip to content

fix: send $effect.pending count to the correct boundary #16732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2025
Merged

fix: send $effect.pending count to the correct boundary #16732

merged 5 commits into from
Sep 9, 2025
+189 −32

Conversation

Rich-Harris
Copy link
Member

alternative to #16729

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 545903f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16732

@sveltejs sveltejs deleted a comment from github-actions bot Sep 9, 2025
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github reviewed Sep 9, 2025
View reviewed changes
packages/svelte/src/internal/client/dom/blocks/boundary.js
@@ -242,12 +263,9 @@ export class Boundary {

/** @param {1 | -1} d */
update_pending_count(d) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDoc to not call this inside class

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rich-Harris Rich-Harris merged commit 18dd456 into main Sep 9, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the effect-pending-correct-boundary branch September 9, 2025 14:28
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @elliott-with-the-longest-name-on-github