chore: simplify batch logic #16838
Merged
chore: simplify batch logic #16838
+17
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elliott-with-the-longest-name-on-github
approved these changes
Sep 25, 2025
* more * remove unnecessary flushSync * simplify
Rich-Harris
added a commit
that referenced
this pull request
Sep 25, 2025
Rich-Harris
added a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working to simplify some of the batching logic as a precursor to a larger overhaul that will hopefully make some of the gnarlier edge cases easier to wrangle.
This is a small step in that direction. Previously, we would reinstate a batch at the end of its life — this is one of those things that gets shoehorned into a codebase just to get the tests passing, but it never really made much sense to me. Turns out we don't need it.
The outcome is a simpler batch lifecycle — when you
flusha batch, it either sticks around because it has pending async work or it gets removed straight away, with no zombie in-between state.More to come in follow-up PRs