Skip to content

Fix warnings in Swift 6.2 about non-sendable types in isolated closures #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Fix warnings in Swift 6.2 about non-sendable types in isolated closures #107

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10986f3
Fix warnings in Swift 6.2 about non-sendable types in isolated closures
d-ronnqvist Jun 4, 2025
3ea68a0
Update the `check-source` script to allow 2025 in the license header.
d-ronnqvist Jun 4, 2025
405b339
Update the necessary license header comment style
d-ronnqvist Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftDocCPluginUtilities/BuildGraph/DocumentationBuildGraph.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2024 Apple Inc. and the Swift project authors
// Copyright (c) 2024-2025 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
Expand All @@ -9,7 +9,7 @@
import Foundation

/// A target that can have a documentation task in the build graph
protocol DocumentationBuildGraphTarget {
protocol DocumentationBuildGraphTarget: SendableMetatype {
typealias ID = String
/// The unique identifier of this target
var id: ID { get }
Expand Down
21 changes: 21 additions & 0 deletions Sources/SwiftDocCPluginUtilities/FoundationExtensions/SendableMetatypeShim.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
This source file is part of the Swift.org open source project

Copyright (c) 2025 Apple Inc. and the Swift project authors
Licensed under Apache License v2.0 with Runtime Library Exception

See https://swift.org/LICENSE.txt for license information
See https://swift.org/CONTRIBUTORS.txt for Swift project authors
*/

// In Swift 6.2, metatypes are no longer sendable by default (SE-0470).
// Instead a type needs to conform to `SendableMetatype` to indicate that its metatype is sendable.
//
// However, `SendableMetatype` doesn't exist before Swift 6.1 so we define an internal alias to `Any` here.
// This means that conformances to `SendableMetatype` has no effect before 6.2 indicates metatype sendability in 6.2 onwards.
//
// Note: Adding a protocol requirement to a _public_ API is a breaking change.

#if compiler(<6.2)
typealias SendableMetatype = Any
#endif
2 changes: 1 addition & 1 deletion bin/check-source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ here="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

function replace_acceptable_years() {
# this needs to replace all acceptable forms with 'YEARS'
sed -e 's/20[12][78901234]-20[12][8901234]/YEARS/' -e 's/20[12][8901234]/YEARS/'
sed -e 's/20[12][789012345]-20[12][89012345]/YEARS/' -e 's/20[12][89012345]/YEARS/'
}

printf "=> Checking for unacceptable language… "
Expand Down