Fix UseSingleLinePropertyGetter dropping comments #1062
+243
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
requested review from
allevato,
bnbarham,
hamishknight and
rintaro
as code owners
TTOzzi
commented
Sep 12, 2025
Comment on lines
-100
to
-101
| extension Trivia { | ||
| func trimmingSuperfluousNewlines(fromClosingBrace: Bool) -> (Trivia, Int) { |
There was a problem hiding this comment.
Moved because it is now used commonly in other places.
(There are no changes to the logic.)
| return 4 | ||
| return 4 |
There was a problem hiding this comment.
In the test cases, some whitespace may appear incorrect, but in actual usage the PrettyPrinter will handle the spacing properly.
TTOzzi
force-pushed
the
single-line-getter
branch
5 times, most recently
from
c8db80e to
d35ee18
Compare
TTOzzi
force-pushed
the
single-line-getter
branch
from
d35ee18 to
a27c222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1056
In addition to the example shown in the issue, various other cases of missing comments were also addressed. I made sure to preserve the original position of comments as much as possible.