Consider variants starting with @- to be invalid (e.g. @-2xl:flex)
#18869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jordan Pittman <[email protected]>
Co-Authored-By: Jordan Pittman <[email protected]>
thecrypticace
approved these changes
Sep 3, 2025
RobinMalfait
changed the title
@-… variants@- to be invalid (e.g. @-2xl:flex)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small parsing issue where variants such as
@-2xl:flexwould parse, but were handled as-if they were@2xl:flexinstead.Noticed this while working on: #18867
This is because when we parse normal variants like
data-foothen we want to have adataroot and afoovalue, not a-foovalue.If you are now using
@-2xl:flex, then no CSS will be generated for this anymore. If you were relying on this for some reason, you should use@2xl:flexinstead.Test plan
Before:
After: