-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(cli): detect Android env and install SDK and NDK if needed #14094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
changes the Android setup to be a bit more automated - looking up ANDROID_HOME and NDK_HOME from common system paths and installing the Android SDK and NDK if needed using the command line tools
Package Changes Through 42237edThere are 4 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri with patch, tauri-build with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
I feel like this is something where sooner or later people will ask us for an opt-out mechanism but we'll see what kind of feedback we'll get, cool change either way |
I feel like we should ask in the cli first before downloading, these packages are quite big and they are stored in the android studio paths (are not in tauri's usual temp directory) |
I agree with @Legend-Master, should be a prompt (defaults to No), and in CI always No. We should also output a list of what changes have we made to their system |
good idea, i'll also link to the docs in case they want to do the process manually |
changes the Android setup to be a bit more automated - looking up ANDROID_HOME and NDK_HOME from common system paths and installing the Android SDK and NDK if needed using the command line tools