Remove hammer.js imports from examples as it is no longer needed #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PekoPPT 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: PekoPPT <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
PekoPPT
September 15, 2025 12:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all Hammer.js imports and dependencies from the KendoReact examples, as Hammer.js is no longer required in the latest version of KendoReact.
Changes Made
Examples Updated (9 total):
import 'hammerjs'from PortfolioChart.jsximport 'hammerjs'from ChartPage.jsximport 'hammerjs'from CostBreakdownChart.jsx and BubbleChart.jsximport 'hammerjs'from BarChartContainer.js and DonutChartContainer.jsimport 'hammerjs'from BarChartContainer.jsximport 'hammerjs'from Stock.tsximport 'hammerjs'from App.jsximport("hammerjs")and conditional logic from Chart.jsximport 'hammerjs'from DetailComponent.jsxPackage Dependencies:
"hammerjs": "^2.0.8"from all affected package.json filesTesting
All modified examples have been tested and confirmed to:
The changes are minimal and surgical, only removing the unnecessary Hammer.js references without affecting any other functionality. Chart interactions, touch gestures, and all other features continue to work as expected with the native KendoReact chart capabilities.
Fixes #2989.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
licensing.telerik.comnode ./bin/kendo-ui-license.js activate --ignore-no-license(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.