Guard no input or output args for functions #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a function lacks input_args or lacks output_args, the graph explorer would be unable to load a graph because input_arg['name'] triggers an error (due to input_arg being undefined). And indeed, functions without inputs (such as one with this signature) as possible: Likewise, nothing stops the `function.Defun` API from making a function without outputs (and only side effects). This change guards those cases.
dsmilkov
approved these changes
Aug 24, 2017
jart
pushed a commit
that referenced
this pull request
Aug 24, 2017
Previously, if a function lacks input_args or lacks output_args, the graph explorer would be unable to load a graph because input_arg['name'] triggers an error (due to input_arg being undefined). And indeed, functions without inputs (such as one with this signature) as possible: Likewise, nothing stops the `function.Defun` API from making a function without outputs (and only side effects). This change guards those cases. Fixes #375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a function lacks input_args or lacks output_args, the
graph explorer would be unable to load a graph because
input_arg['name']triggers an error (due to input_arg being undefined).And indeed, functions without inputs (such as one with this signature from #375)
are possible:
Likewise, nothing stops the
function.DefunAPI from making a functionwithout outputs (and only side effects).
This change guards those cases. Fixes #375. I can view the graph from the TensorFlow workshop (07_structured_data.ipynb) after this change: