Add demo data for op_profile view #501
Conversation
| @@ -33,6 +33,7 @@ | |||
| from tensorboard.plugins.profile import profile_demo_data | |||
| from tensorboard.plugins.profile import profile_plugin | |||
| from tensorboard.plugins.profile import trace_events_pb2 | |||
| from shutil import copyfile | |||
There was a problem hiding this comment.
Could you replace with import shutil and move it near to import os? Native imports come first, and python style is to import the module, then use it.
There was a problem hiding this comment.
I just have this 1 comment, and then lets merge. Thanks!
There was a problem hiding this comment.
Done. (Sorry, not sure how I missed this)
| @@ -0,0 +1,95 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this expected? I see nothing in the parentheses.
There was a problem hiding this comment.
Also, "is overhead, and a good target for optimization" is a dangling half-sentence. I think something might be missing there.
|
Good catch - I left too much out when constructing the data by hand, and the "_worstOp" calculation was crashing. |
The data is about the minimal set that exercises all current features (and #484)
For brevity, it omits some "required" stuff we don't currently use, like the byProgramStructure tree, and the raw{Time,Flops} metrics.
@ioeric