Load new projector config when dataset changes #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the data provider changed, a new projector config might not load because the name of the new run (string) could stay the same - indeed the name of the run is always 'proto'. This change makes it so that we load a new projector config and correspondingly update the UI when the data provider changes (even if the run name changes). Fixes #478. This commit is coauthored by @svsgoogle and @chihuahua.
chihuahua
force-pushed
the
chihuahua-projector
branch
from
95f9d7e to
87c5af3
Compare
dsmilkov
approved these changes
Sep 18, 2017
jart
pushed a commit
to jart/tensorboard
that referenced
this pull request
Sep 23, 2017
Previously, when the data provider changed, a new projector config might not load because the name of the new run (string) could stay the same - indeed the name of the run is always 'proto'. This change makes it so that we load a new projector config and correspondingly update the UI when the data provider changes (even if the run name changes). Fixes tensorflow#478. This commit is coauthored by @svsgoogle and @chihuahua.
jart
pushed a commit
that referenced
this pull request
Sep 26, 2017
Previously, when the data provider changed, a new projector config might not load because the name of the new run (string) could stay the same - indeed the name of the run is always 'proto'. This change makes it so that we load a new projector config and correspondingly update the UI when the data provider changes (even if the run name changes). Fixes #478. This commit is coauthored by @svsgoogle and @chihuahua.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the data provider changed, a new projector config might not load because the name of the new run (string) could stay the same - indeed the name of the run is always 'proto'.
This change makes it so that we load a new projector config and correspondingly update the UI when the data provider changes (even if the run name changes).
Fixes #478. This commit is coauthored by @svsgoogle and @chihuahua.