-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add example for GKE confidential nodes with GPU #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add example for GKE confidential nodes with GPU #2426
Conversation
@apeabody could you please run the build for this PR? |
/gcbrun |
@apeabody I don't have access to the GCP cloud build project. Could you please send me the error? |
|
@apeabody could you please re-run the build? |
/gcbrun |
@apeabody I think the build wasn't properly triggered, could you please take a look? |
/gcbrun |
Might have been too quick after the merge, it's running now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arthurlapertosa!
content { | ||
enabled = confidential_nodes.value.enabled | ||
{% if autopilot_cluster != true %} | ||
confidential_instance_type = lookup(var.node_pools[0], "confidential_instance_type", null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document any new node_pool parameters in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/autogen/main/README.md?plain=1#L190
No description provided.