Follow up of the terraform_map_duplicate_keys
rule
#196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #194
This fixes some issues with the
terraform_map_duplicate_keys
rule added in #194.First,
EvaluateExpr
call fails due to terraform-linters/tflint-plugin-sdk#338 if map key is a naked identifier.To prevent this, we need to get the values of the keys in a way similar to
ObjectConsKeyExpr.Value
as a workaround.https://github.com/hashicorp/hcl/blob/v2.21.0/hclsyntax/expression.go#L1311-L1338
Second, since
val.AsString
can panic on sensitive values or non-string keys, This PR made it ignore these.Finally, I fixed an issue where added rules were not registered in presets and there was a lack of documentation.