Skip to content

Use helper.AssertIssues fixed in SDK v0.22 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Use helper.AssertIssues fixed in SDK v0.22 #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 1 addition & 33 deletions rules/terraform_required_providers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
package rules

import (
"reflect"
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/hashicorp/hcl/v2"
"github.com/terraform-linters/tflint-plugin-sdk/helper"
"github.com/terraform-linters/tflint-plugin-sdk/tflint"
)

func Test_TerraformRequiredProvidersRule(t *testing.T) {
Expand Down Expand Up @@ -695,35 +691,7 @@ terraform {
t.Fatalf("Unexpected error occurred: %s", err)
}

// TODO: replace the following assertions without ordering by AssertIssues
// helper.AssertIssues(t, tc.Expected, runner.Runner.(*helper.Runner).Issues)
opts := []cmp.Option{
cmpopts.IgnoreFields(hcl.Pos{}, "Byte"),
cmp.Comparer(func(x, y tflint.Rule) bool {
return reflect.TypeOf(x) == reflect.TypeOf(y)
}),
cmpopts.SortSlices(func(i, j *helper.Issue) bool {
if i.Range.Filename != j.Range.Filename {
return i.Range.Filename < j.Range.Filename
}
if i.Range.Start.Line != j.Range.Start.Line {
return i.Range.Start.Line < j.Range.Start.Line
}
if i.Range.Start.Column != j.Range.Start.Column {
return i.Range.Start.Column < j.Range.Start.Column
}
if i.Range.End.Line != j.Range.End.Line {
return i.Range.End.Line > j.Range.End.Line
}
if i.Range.End.Column != j.Range.End.Column {
return i.Range.End.Column > j.Range.End.Column
}
return i.Message < j.Message
}),
}
if diff := cmp.Diff(tc.Expected, runner.Runner.(*helper.Runner).Issues, opts...); diff != "" {
t.Fatalf("Expected issues are not matched:\n %s\n", diff)
}
helper.AssertIssues(t, tc.Expected, runner.Runner.(*helper.Runner).Issues)
want := map[string]string{}
if tc.Fixed != "" {
want[filename] = tc.Fixed
Expand Down