Skip to content

Conversation

chernetskyi
Copy link
Contributor

@chernetskyi chernetskyi commented Jun 23, 2025

Closes #256

Copy link
Member

@bendrucker bendrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There are some tricky details to commit detection but overall this looks good. Left some suggestions around tightening up the documentation.

@chernetskyi chernetskyi requested a review from bendrucker June 29, 2025 10:25
Copy link
Member

@bendrucker bendrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping after this! There's still some work to be done to harden the commit vs branch/tag detection. Even with the rule disabled by default, emitting invalid advice for unpunctuated branch names is a costly false positive.

The key to more sophisticated behavior will be having a very comprehensive suite of test cases to verify against.

@chernetskyi chernetskyi requested a review from bendrucker July 1, 2025 07:28
@bendrucker bendrucker merged commit 3232af1 into terraform-linters:main Jul 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants