-
Notifications
You must be signed in to change notification settings - Fork 28
Add terraform_module_shallow_clone rule #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! There are some tricky details to commit detection but overall this looks good. Left some suggestions around tightening up the documentation.
Co-authored-by: Ben Drucker <[email protected]>
Co-authored-by: Ben Drucker <[email protected]>
Co-authored-by: Ben Drucker <[email protected]>
Co-authored-by: Ben Drucker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping after this! There's still some work to be done to harden the commit vs branch/tag detection. Even with the rule disabled by default, emitting invalid advice for unpunctuated branch names is a costly false positive.
The key to more sophisticated behavior will be having a very comprehensive suite of test cases to verify against.
Co-authored-by: Ben Drucker <[email protected]>
Closes #256