Skip to content

Conversation

klamike
Copy link
Contributor

@klamike klamike commented Jul 28, 2025

Adds JuliaWeb/HTTP.jl, based on #8482

This will grab the latest HTTP.jl with major version 1 and minor version greater than 10, though note work is under way for version 2 at JuliaWeb/HTTP.jl#1213. When that is merged the compat will need to be bumped.

Does the benchmark do any warmup requests? This is important to get good results in Julia since it is doing lazy compilation on the first requests.

@klamike klamike requested a review from waghanza as a code owner July 28, 2025 21:02
@waghanza
Copy link
Collaborator

waghanza commented Jul 29, 2025

Hi @klamike ,

Could you ping some authors for reviews ?

This benchmark does a warmup phase, I have to change the documentation to reflect that.

Regards,

Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes

klamike and others added 2 commits July 29, 2025 11:39
Co-authored-by: Marwan Rabbâa <[email protected]>
Co-authored-by: Marwan Rabbâa <[email protected]>
@klamike
Copy link
Contributor Author

klamike commented Jul 29, 2025

Could you ping some authors for reviews ?

Is this necessary? The code is MIT, I'm confident the usage is correct since it is so simple, and I'm happy to maintain this code myself if you want to expand the benchmark in the future.

Just looking out for their time. I think most of the contributors to HTTP.jl are involved in lots of packages, there is no "dedicated maintainer" AFAIK.

@waghanza
Copy link
Collaborator

I'm sure of it @klamike , and glad you which to maintain HTTP.jl implementation here.

The idea is just to notify any author to pay respect, and let them the chance to "say no". It occurs a few times that authors have been opposd to include it here.

I do not understand this kind of decision, but I pledge to respect it for this benchmark. I hope you understand.

@waghanza
Copy link
Collaborator

@BioTurboNick @quinnj we plan to introduce HTTP.jl here.

Despote the MIT licence, I which to pong some authors to see if this is accurate ...

And of course if this is OK for you, I mean if somebody do not want it to be include here, we won't

@waghanza
Copy link
Collaborator

waghanza commented Jul 31, 2025

If no explicit refusal, I'll merge before updating results @klamike

@BioTurboNick
Copy link

I'm not an author of it, I just made a small PR recently.

@waghanza waghanza merged commit 2a93f54 into the-benchmarker:master Aug 8, 2025
2 checks passed
@quinnj
Copy link

quinnj commented Aug 8, 2025

Yeah, fine by me. Note that we'll hopefully be merging/releasing the 2.0 release soon, which completely overhauls the internals to use the aws-c-http library under the hood (instead of the current mishmash of pure julia + openssl + libuv).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants