Code improvements #510
Merged
Code improvements #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g performance difference.
…minimum php version is 8.0
…n where needed. Consequently, remove phpstan/phpstan-webmozart-assert.
andrew-demb
reviewed
Sep 1, 2022
Codecov ReportBase: 95.85% // Head: 95.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
============================================
- Coverage 95.85% 95.74% -0.12%
+ Complexity 1766 1765 -1
============================================
Files 153 153
Lines 4319 4274 -45
============================================
- Hits 4140 4092 -48
- Misses 179 182 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Seems like last review issue resolved, can it be merged? |
|
It can - looks great. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#417
Remove webmozart/assert and phpstan/phpstan-webmozart-assert library. Replace it with native assertion.
Type safety improvement.