Bump doctrine/annotations to v2 #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v6.2.1 released |
|
@oojacoboo can these changes also be ported to graphqlite bundle and graphqlite symfony validator bridge, both packages currently depend upon doctrine/annotations v1 |
|
@faizanakram99 I'm sure they can be. You're welcome to submit PRs there for getting merged. I'm not maintaining those framework implementations though. |
|
Hey Folks, already merged for 'symfony validator bridge' thecodingmachine/graphqlite-symfony-validator-bridge#69. Will do the same for graphqlite bundle |
|
Done also, both repos have been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #579
There was some backward-incompatible exception messages with phpdoc-like annotation in tests, so I replaced it with attributes.