-
Notifications
You must be signed in to change notification settings - Fork 103
Automatic query complexity #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6aee9ca
Automatic query complexity
oprypkhantc f7d55ad
Merge branch 'master' into cost
oprypkhantc 8373864
Fix tests after master merge
oprypkhantc 1a35b1e
Code style
oprypkhantc 18fcf0d
Add annotation reference and add some tests
oprypkhantc 775dc9e
Fix PHPStan fails
oprypkhantc c47bb52
Fix PHPUnit test on prefer-lowest
oprypkhantc 4377ab8
Fix docs generation
oprypkhantc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace TheCodingMachine\GraphQLite\Annotations; | ||
|
||
use Attribute; | ||
|
||
#[Attribute(Attribute::TARGET_PROPERTY | Attribute::TARGET_METHOD)] | ||
class Cost implements MiddlewareAnnotationInterface | ||
{ | ||
/** | ||
* @param int $complexity Complexity for that field | ||
* @param string[] $multipliers Names of fields by value of which complexity will be multiplied | ||
* @param ?int $defaultMultiplier Default multiplier value if all multipliers are missing/null | ||
*/ | ||
public function __construct( | ||
public readonly int $complexity = 1, | ||
public readonly array $multipliers = [], | ||
public readonly int|null $defaultMultiplier = null, | ||
) { | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace TheCodingMachine\GraphQLite\Middlewares; | ||
|
||
use GraphQL\Type\Definition\FieldDefinition; | ||
use TheCodingMachine\GraphQLite\Annotations\Cost; | ||
use TheCodingMachine\GraphQLite\QueryFieldDescriptor; | ||
|
||
use function implode; | ||
use function is_int; | ||
|
||
/** | ||
* Reference implementation: https://github.com/ChilliCream/graphql-platform/blob/388f5c988bbb806e46e2315f1844ea5bb63096f2/src/HotChocolate/Core/src/Execution/Options/ComplexityAnalyzerSettings.cs#L58 | ||
*/ | ||
class CostFieldMiddleware implements FieldMiddlewareInterface | ||
{ | ||
public function process(QueryFieldDescriptor $queryFieldDescriptor, FieldHandlerInterface $fieldHandler): FieldDefinition|null | ||
{ | ||
$costAttribute = $queryFieldDescriptor->getMiddlewareAnnotations()->getAnnotationByType(Cost::class); | ||
|
||
if (! $costAttribute) { | ||
return $fieldHandler->handle($queryFieldDescriptor); | ||
} | ||
|
||
$field = $fieldHandler->handle( | ||
$queryFieldDescriptor->withAddedCommentLines($this->buildQueryComment($costAttribute)), | ||
); | ||
|
||
if (! $field) { | ||
return $field; | ||
} | ||
|
||
$field->complexityFn = static function (int $childrenComplexity, array $fieldArguments) use ($costAttribute): int { | ||
if (! $costAttribute->multipliers) { | ||
return $costAttribute->complexity + $childrenComplexity; | ||
} | ||
|
||
$cost = $costAttribute->complexity + $childrenComplexity; | ||
$needsDefaultMultiplier = true; | ||
|
||
foreach ($costAttribute->multipliers as $multiplier) { | ||
$value = $fieldArguments[$multiplier] ?? null; | ||
|
||
if (! is_int($value)) { | ||
continue; | ||
} | ||
|
||
$cost *= $value; | ||
$needsDefaultMultiplier = false; | ||
} | ||
|
||
if ($needsDefaultMultiplier && $costAttribute->defaultMultiplier !== null) { | ||
$cost *= $costAttribute->defaultMultiplier; | ||
} | ||
|
||
return $cost; | ||
}; | ||
|
||
return $field; | ||
} | ||
|
||
private function buildQueryComment(Cost $costAttribute): string | ||
{ | ||
return 'Cost: ' . | ||
oprypkhantc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
implode(', ', [ | ||
'complexity = ' . $costAttribute->complexity, | ||
'multipliers = [' . implode(', ', $costAttribute->multipliers) . ']', | ||
'defaultMultiplier = ' . ($costAttribute->defaultMultiplier ?? 'null'), | ||
]); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.