Skip to content

Conversation

dpaoliello
Copy link

We recently hit a build error in the Rust compiler when trying to bump cc that came from jemalloc-sys while calling configure, but since the build script only shows the last 100 lines, we couldn't see the actual error in the build log: rust-lang/rust#146186 (comment)

This change replaces tail 100 with cat so that the entire configure log is printed in the build output.

Copy link

ti-chi-bot bot commented Sep 8, 2025

Welcome @dpaoliello! It looks like this is your first PR to tikv/jemallocator 🎉

@BusyJay
Copy link
Member

BusyJay commented Sep 23, 2025

That will be too long for general terminal. I think we should distinguish between CI and regular build, perhaps via some environment flag?

@dpaoliello
Copy link
Author

The common way is to check CI, seems to be supported by most CI infra: https://stackoverflow.com/a/75223617/2364261

Signed-off-by: Daniel Paoliello <[email protected]>
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BusyJay BusyJay merged commit 009e71f into tikv:main Sep 24, 2025
10 checks passed
@dpaoliello dpaoliello deleted the cat branch September 24, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants