util: add JoinDeque structure #7590
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickkuk
force-pushed
the
join_deque
branch
3 times, most recently
from
2068e58 to
bab83ad
Compare
ADD-SP
reviewed
Sep 9, 2025
tokio-util/src/task/join_deque.rs
Outdated
| /// When the `JoinDeque` is dropped, all tasks in the `JoinDeque` are | ||
| /// immediately aborted. | ||
| #[derive(Debug)] | ||
| pub struct JoinDeque<T>(VecDeque<JoinHandle<T>>); |
There was a problem hiding this comment.
tokio_util::task::AbortOnDropHandle would be better.
ADD-SP
reviewed
Sep 9, 2025
tokio-util/src/task/join_deque.rs
Outdated
Comment on lines
24
to
30
| impl<T> Drop for JoinDeque<T> { | ||
| fn drop(&mut self) { | ||
| for join_handle in self.0.drain(..) { | ||
| join_handle.abort(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| impl<T> Drop for JoinDeque<T> { | |
| fn drop(&mut self) { | |
| for join_handle in self.0.drain(..) { | |
| join_handle.abort(); | |
| } | |
| } | |
| } |
See #7590 (comment)
ADD-SP
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
tokio_util::task::JoinDequestructure as FIFO-ordered analog oftokio::task::JoinSet.Issue: #7576