-
-
Notifications
You must be signed in to change notification settings - Fork 302
chore: remove regenerator-runtime dependency and update react-intersection-observer to 9.11.0 #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ction-observer to 9.11.0
WalkthroughUpdated a dependency version in package.json, removed a dependency, and deleted a corresponding polyfill import from the app entry point. No other files or logic were changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
webapp/package.json (1)
48-48
: Runtime polyfill expectationsreact-intersection-observer relies on native IntersectionObserver; your browserslist excludes legacy browsers, so no polyfill should be needed. If you still SSR anywhere, ensure calls remain guarded (library typically no-ops on server).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
webapp/package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (2)
webapp/package.json
(1 hunks)webapp/src/index.tsx
(0 hunks)
💤 Files with no reviewable changes (1)
- webapp/src/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
- GitHub Check: E2E testing 🔎 (15, 14)
- GitHub Check: E2E testing 🔎 (15, 13)
- GitHub Check: E2E testing 🔎 (15, 12)
- GitHub Check: E2E testing 🔎 (15, 7)
- GitHub Check: E2E testing 🔎 (15, 10)
- GitHub Check: E2E testing 🔎 (15, 9)
- GitHub Check: E2E testing 🔎 (15, 6)
- GitHub Check: E2E testing 🔎 (15, 11)
- GitHub Check: E2E testing 🔎 (15, 5)
- GitHub Check: E2E testing 🔎 (15, 4)
- GitHub Check: E2E testing 🔎 (15, 1)
- GitHub Check: E2E testing 🔎 (15, 2)
- GitHub Check: E2E testing 🔎 (15, 8)
- GitHub Check: E2E testing 🔎 (15, 0)
- GitHub Check: E2E testing 🔎 (15, 3)
- GitHub Check: BT 🔎 (security:test)
- GitHub Check: BT 🔎 (ktlint:test)
- GitHub Check: BT 🔎 (server-app:runStandardTests)
- GitHub Check: BT 🔎 (data:test)
- GitHub Check: BT 🔎 (server-app:runWebsocketTests)
- GitHub Check: BT 🔎 (ee-test:test)
- GitHub Check: BT 🔎 (server-app:runWithoutEeTests)
- GitHub Check: BT 🔎 (server-app:runContextRecreatingTests)
- GitHub Check: Frontend static check 🪲
🔇 Additional comments (2)
webapp/package.json (2)
48-48
: react-intersection-observer → ^9.11.0: approved for React 17
Changelog shows only removal of the publish-dist script in 9.11.0 — no API or breaking changes vs 9.10.x; safe to upgrade.
6-64
: Regenerator-runtime removal — no direct usages found; validate test/CRACOInspected webapp/package.json (no regenerator-runtime), webapp/tsconfig.json (target: ESNext), webapp/jest.config.js (preset: 'ts-jest'); npm --prefix webapp ls regenerator-runtime → not installed. However package.json test script uses "craco test" and repo-wide ripgrep checks were inconclusive for CRACO/Babel configs — confirm CRACO/Babel or CI toolchain will not inject regenerator transforms by running a local install + tests (npm ci && npm test) or by verifying CI/monorepo test config.
Remove regenerator-runtime dependency
Summary
Removes obsolete
regenerator-runtime
dependency that's no longer needed with our modern Vite + ESNext build setup.Changes
regenerator-runtime
dependency and importreact-intersection-observer
to^9.11.0
Why?
ESNext
and browserslist targets modern browsersImpact
Summary by CodeRabbit