WebUI: Making PRs with no changes closable #9294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom being hidden by the alert
itaigilo
added
the
include-changelog
itaigilo
changed the title
Ben-El
approved these changes
Jul 14, 2025
|
LGTM |
…thout-changes-8690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8690
Previously, the "Close pull request" button did not appear on PRs with no changes.
This turned out to be a UI issue, as the close\merge buttons were rendered but just covered by "merging is disabled.." alert.
Changing the bottom-buttons-group div to use flexbox seems to have solved the issue.
The existing code already makes the merge button disabled in the case of an empty merge.