TensorRT Cuda Context Sharing #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturley-hall
requested review from
tanmayv25,
nnshah1,
mc-nv,
nv-kmcgill53 and
GuanLuo
mc-nv
reviewed
Feb 12, 2025
There was a problem hiding this comment.
This change is Windows only as per my understanding, CMakeLists.txt doesn't reflect it and it cause a confusion.
Is it something that we consider to build by default then configuration change should reflect it accordingly.
mc-nv
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Files in src folder may be related not only to Windows but other platforms as well. We need to make sure it doesn't impact the container build.
@GuanLuo are we OK with it?
@saturley-hall have we tested it well in CI for other stacks are we confident with result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enabled cuda context sharing with CiG streams on Windows Gaming applications