Skip to content

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 11, 2024

  • remove trailing slash
  • use urls.JoinPath
  • reindent

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR marked this pull request as ready for review March 11, 2024 11:16
@XhmikosR XhmikosR force-pushed the xmr/examples branch 2 times, most recently from c377de6 to c8d9d8f Compare March 11, 2024 13:59
@XhmikosR XhmikosR changed the title examples: minor tweaks examples: assorted tweaks Mar 11, 2024
* remove trailing slash
* use urls.JoinPath
* reindent
* use `imageConfig` so that we add dimensions automatically
@XhmikosR XhmikosR merged commit ab1a765 into main Mar 12, 2024
@XhmikosR XhmikosR deleted the xmr/examples branch March 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants