Skip to content

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jun 25, 2024

Description

Fixes an accessibility issue reported by Axe Core.
REF: https://dequeuniversity.com/rules/axe/4.8/landmark-one-main

Motivation & Context

Makes is easier for accessibility tools to navigate by landmarks

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @coliff for the patch.
I'm handing the PR over to @patrickhlauke for a11y final check, just to be 100% sure 😇

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that it's only a best practice, not an actual failure...but sure

@julien-deramond julien-deramond merged commit 008bc23 into twbs:main Jun 25, 2024
@coliff coliff deleted the dev/coliff/cheatsheet-main-a11y-fix branch June 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants