Skip to content

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 5, 2025

Replaces #39158, fixes #39114.

@mdo mdo requested a review from a team as a code owner August 5, 2025 09:21
@mdo mdo added this to v5.3.8 Aug 5, 2025
@mdo mdo added the css label Aug 5, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.8 Aug 5, 2025
@coliff
Copy link
Contributor

coliff commented Aug 5, 2025

Please consider making it grey too (with filter: grayscale(1);)! 🙏
RE: #39335
I don't like it appearing blue in Chrome/Edge on Windows (it's grey in Firefox and Safari)

@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.8 Aug 5, 2025
@julien-deramond julien-deramond moved this from Needs review to Review in progress in v5.3.8 Aug 5, 2025
@julien-deramond julien-deramond self-requested a review August 5, 2025 19:30
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm open to incorporating the suggestion from @coliff (see #39335). The cancel button isn't influenced by any CSS rules or accent-color, so using a grayish tone feels more neutral than the default blue.

If you're on board, we can either include the change here or handle it in a follow-up PR; whichever you prefer.

@mdo mdo merged commit 47c75b8 into main Aug 20, 2025
14 checks passed
@mdo mdo deleted the mdo/input-search-cancel branch August 20, 2025 18:13
@github-project-automation github-project-automation bot moved this from Review in progress to Done in v5.3.8 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add cursor-pointer rule for search clear
3 participants