Skip to content

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 27, 2022

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR updates the app so that the settings related to Grid Mode are persisted between visits (using local storage). A new hook, useLocalStorageState was created so that we don't have to duplicate the same local storage local throughout the app. This hook was also added to the useBackgroundSettings hook to simplify it a little.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from charliesantos May 27, 2022 22:57
@timmydoza timmydoza merged commit e4e1ffd into feature/grid-mode Jun 1, 2022
@timmydoza timmydoza deleted the VIDEO-10096-persist-grid-settings branch June 1, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants