USWDS - Storybook: Update storybook to v8 #6447
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Mazzanti <[email protected]>
|
@anmazz this would be cool to see merged, thanks for working on this! I was poking around and noticed there's this weird quirk on refresh where component styles (like Banner) disappear on refresh. CleanShot.2025-08-20.at.20.50.23.mp4 |
|
@mejiaj set it to explicitly load the scss in preview.js, so should work! I saw the same issue you described and this fixed it for me. |
|
Nice, it's working for me now too. Thanks @anmazz! This will be a nice update because storybook is currently on version 6. |
|
@annepetersen or @heymatthenry this is ready for review. It's a big jump from 6 → 8, but could help with performance and security. https://storybook.js.org/docs/8/migration-guide/from-older-version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates Storybook to version 8.6.7 (latest non-beta version as of Mar. 20, 2025).
Breaking change
Related issue
Closes #5239
Problem statement
Storybook was using an old version and can be updated to support the latest, version 8.
Solution
I followed the automatic migration as well as the migration guide here: https://storybook.js.org/docs/9/migration-guide
I tried maintaining as much existing code as possible. I believe, for instance, that the
"../packages/**/*.stories.mdx",could be removed frommain.js, but kept it in for now pending comment.Major changes
@storybook/html-webpack5and dependenciesTesting and review
Run storybook and verify that storybook version has been upgraded and works as usual.
Dependency updates