Improve the locale support #7981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances locale support by improving fallback behavior, removing the default locale configuration, and adding tests to cover these changes.
- Updated locale generation commands to include Spanish UTF-8 support.
- Adjusted workflow configurations to improve locale fallback consistency.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
May 25, 2025
cakebaker
reviewed
May 25, 2025
cakebaker
reviewed
May 25, 2025
| fn format(&self, id: &str, args: Option<&FluentArgs>, default: &str) -> String { | ||
| match self.bundle.get_message(id).and_then(|m| m.value()) { | ||
| Some(value) => { | ||
| fn format(&self, id: &str, args: Option<&FluentArgs>) -> String { |
There was a problem hiding this comment.
I think it would be more logical to return an Option<String> to distinguish between found/not found.
There was a problem hiding this comment.
if not found, i think we should just return the id instead of an empty string.
it isn't ideal but better than an empty string
no ?
There was a problem hiding this comment.
Hm, it wouldn't be an empty string but None.
sylvestre
force-pushed
the
locale2
branch
2 times, most recently
from
888542f to
8882cd8
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
cakebaker
reviewed
May 28, 2025
* remove the default value. Avoid duplication of the english string + facilitate translation * have english as a default. Load english when the translated string isn't available
|
GNU testsuite comparison: |
|
Good job, now we have the first (partially) bilingual util :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the fallback + remove the default + add tests