Skip to content

cp: migrate from quick-error to thiserror #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

cp: migrate from quick-error to thiserror #7989

merged 4 commits into from
Jun 3, 2025

Conversation

vikram-kangotra
Copy link
Contributor

Migrate cp error handling from quick-error to thiserror and remove the quick-error crate.

sylvestre
sylvestre reviewed May 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@vikram-kangotra vikram-kangotra force-pushed the migrate-to-thiserror branch 2 times, most recently from 2657ac1 to 05acf0e Compare May 27, 2025 14:47
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker force-pushed the migrate-to-thiserror branch from 4db6863 to ec59f0d Compare June 3, 2025 07:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit bfbdd52 into uutils:main Jun 3, 2025
74 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR!

@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikram-kangotra @cakebaker @sylvestre