Skip to content

expr: Fix handling of regex range quantifiers #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 27, 2025
Merged

expr: Fix handling of regex range quantifiers #8010

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7789ef4
expr: handle `\{` literally at the start of an expression
frendsick May 26, 2025
bbc912e
expr: Add tests for regex range quantifiers
frendsick May 27, 2025
874a930
expr: Remove nonexistent error `UnmatchedClosingBrace`
frendsick May 27, 2025
3065482
expr: Anchor regex for detecting range quantifier
frendsick May 27, 2025
6b49b26
expr: Remove redundant tests that should not work anymore
frendsick May 27, 2025
639310c
expr: Fix testing `UnmatchedOpeningBrace`
frendsick May 27, 2025
b1a9135
expr: Ignore test cases from spell checker
frendsick May 27, 2025
6aeae43
expr: Simplify verifying indexes within regex range quantifier
frendsick May 27, 2025
07caa48
expr: Fix error message for too big range quantifier index
frendsick May 27, 2025
ce0c232
expr: Remove redundant checks for `UnmatchedOpeningBrace`
frendsick May 27, 2025
210f4f7
expr: Simplify parsing a range quantifier
frendsick May 27, 2025
ca6a10e
expr: Only '^' requires special treatment at the start of regex
frendsick May 27, 2025
2b56561
expr: Fix parsing regex range quantifier
frendsick May 27, 2025
74ad163
expr: Fix regex for validating range quantifier
frendsick May 27, 2025
4946922
expr: Fix error message for large numbers as range index
frendsick May 27, 2025
eb7bc2f
expr: Allow only ASCII digits for regex range quantifiers
frendsick May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/uu/expr/src/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ pub enum ExprError {
UnmatchedClosingParenthesis,
#[error("Unmatched \\{{")]
UnmatchedOpeningBrace,
#[error("Unmatched ) or \\}}")]
UnmatchedClosingBrace,
#[error("Invalid content of \\{{\\}}")]
InvalidBracketContent,
#[error("Trailing backslash")]
TrailingBackslash,
#[error("Regular expression too big")]
TooBigRangeQuantifierIndex,
}

impl UError for ExprError {
Expand Down
Loading
Loading