Skip to content

Conversation

jtracey
Copy link
Contributor

@jtracey jtracey commented May 28, 2025

  1. Safe wrappers exist for the unix side of things, so let's use those.
  2. A function isn't unsafe just because it uses unsafe code, it's only unsafe if it can be invoked in a way that violates safety guarantees.
  3. Safety comments shouldn't document why something is unsafe, they're for documenting either how to invoke something unsafe safely, or why the unsafe invocation is actually safe.

jtracey added 2 commits May 27, 2025 22:26
The libc crate now exposes Android's sync like other unix platforms.
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

excellent, thanks

@sylvestre sylvestre merged commit 15f606a into uutils:main May 28, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants