stdbuf: add feat_external_libstdbuf #8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecordonnier
commented
Jun 7, 2025
.cargo/config.toml
Outdated
| @@ -3,6 +3,7 @@ linker = "x86_64-unknown-redox-gcc" | |||
|
|
|||
| [env] | |||
| PROJECT_NAME_FOR_VERSION_STRING = "uutils coreutils" | |||
| LIBSTDBUF_PATH = "/usr/lib/libstdbuf.so" | |||
There was a problem hiding this comment.
Actually I did not want to include this line, and wanted the build to fail per default when enabling feat_external_stdbuf, so that people who are packaging uutils-coreutils notice that they need to set this variable.
The issue is that the pre-commit hook calls clippy with "all-features".
Can I use something like this in the pre-commit file?
sh -c 'LIBSTDBUF_PATH=libstdbuf.so cargo +stable clippy --workspace --all-targets --all-features -- -D warnings'
I guess not, because the pre-commit hook is also supposed to work on windows?
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/stdbuf-external
branch
from
e07d23d to
9f309b9
Compare
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/stdbuf-external
branch
from
9f309b9 to
8f1648d
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Jun 13, 2025
| @@ -3,6 +3,7 @@ linker = "x86_64-unknown-redox-gcc" | |||
|
|
|||
| [env] | |||
| PROJECT_NAME_FOR_VERSION_STRING = "uutils coreutils" | |||
| LIBSTDBUF_DIR = "/usr/lib" | |||
There was a problem hiding this comment.
please add that it is explained in src/uu/stdbuf/Cargo.toml
There was a problem hiding this comment.
@sylvestre are there other things which I should change?
Fixes uutils#6591 "feat_external_stdbuf": use an external libstdbuf.so for stdbuf instead of embedding it into the stdbuf binary. There are 2 use-cases: 1. Installation of uutils-coreutils using cargo install (e.g. from crates.io which supports only "cargo install" as installation method). In this case, installing libstdbuf.so is impossible, because "cargo install" installs only binary programs (no cdylib), thus libstdbuf.so must be embedded into stdbuf and written to /tmp at runtime. This is a hack, and may not work on some platforms, e.g. because the SELinux permissions may not allow stdbuf to write to /tmp, /tmp may be read-only, libstdbuf.so may not work at all without SELinux labels, etc. 2. Installation of uutils-coreutils using an external tool, e.g. dpkg/apt on debian. In this case, libstdbuf.so should be installed separately to its correct location and the environment variable LIBSTDBUF_PATH configures the installation path during the build. E.g. LIBSTDBUF_PATH="/lib/libstdbuf.so" Signed-off-by: Etienne Cordonnier <[email protected]>
Ecordonnier
force-pushed
the
eco/stdbuf-external
branch
from
8f1648d to
99aa51a
Compare
Ecordonnier
changed the title
|
GNU testsuite comparison: |
|
ok, let's try with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6591
"feat_external_libstdbuf": use an external libstdbuf.so for stdbuf instead of embedding it into
the stdbuf binary.
There are 2 use-cases:
Installation of uutils-coreutils using cargo install (e.g. from crates.io which supports only "cargo install" as installation method). In this case, installing libstdbuf.so is impossible, because "cargo install" installs only binary programs (no cdylib), thus libstdbuf.so must be embedded into stdbuf and written to /tmp at runtime. This is a hack, and may not work on some platforms, e.g. because the SELinux permissions may not allow stdbuf to write to /tmp, /tmp may be read-only, libstdbuf.so may not work at all without SELinux labels, etc.
Installation of uutils-coreutils using an external tool, e.g. dpkg/apt on debian. In this case, libstdbuf.so should be installed separately to its correct location and the environment variable LIBSTDBUF_DIR configures the installation path during the build. E.g. LIBSTDBUF_DIR="/usr/lib"