Skip to content

Fix the last two GNU tests for fmt #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Fix the last two GNU tests for fmt #8264

merged 2 commits into from
Jun 30, 2025

Conversation

sylvestre
Copy link
Contributor

No description provided.

@sylvestre sylvestre changed the title Fix fmt Fix the last two GNU tests for fmt Jun 24, 2025
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/fmt/goal-option is no longer failing!

cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
tests/by-util/test_fmt.rs
#[test]
fn test_fmt_unicode_whitespace_handling() {
// Test that Unicode whitespace characters like non-breaking space are NOT treated as whitespace
// This prevents regression of the character classification fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what "character classification fix" refers to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i improved the wording

cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/fmt/goal-option is no longer failing!

@cakebaker cakebaker merged commit 5ce678b into uutils:main Jun 30, 2025
76 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/fmt/goal-option is no longer failing!

Great :)

@sylvestre sylvestre deleted the fix-fmt branch June 30, 2025 12:50
@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker