stty: refactor arg processing loop #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willshuttleworth
force-pushed
the
stty-refactor
branch
from
e5aa9b0 to
a653a21
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 21, 2025
willshuttleworth
force-pushed
the
stty-refactor
branch
from
a653a21 to
f836889
Compare
|
GNU testsuite comparison: |
|
Nice refactoring, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework loop that parses and collects stty's args
matchblock at top of loopmatchblockthis is only a basic reorganization that uses an extra match block for readability, and moves some other control flow around so it is better organized.