Fix mkdir with non-unicode parameters #8367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used there anyway.
collect_lossy incorrectly converts invalid UTF-8 strings, let's keep the OsString everywhere. This also means we need to modify strip_minus_from_mode to make it work with OsString.
Let's not reinvent stuff.
Similar to what file_exists does, allows us to pass an OsStr to the function. Also change symlink_exists, for consistency.
Similar to the first part of GNU test df/problematic-chars.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #8357. Overall, I think we should review all uses of
collect_lossy(), they might all be wrong.test_mkdir: Add a test for non-Unicode directory name
Similar to the first part of GNU test df/problematic-chars.
uutests: Change dir_exists to take a templated AsRef
Similar to what file_exists does, allows us to pass an OsStr to the
function.
Also change symlink_exists, for consistency.
mkdir: strip_minus_from_mode: Use uucore functions
Let's not reinvent stuff.
mkdir: Collect OsString, instead of String.
collect_lossy incorrectly converts invalid UTF-8 strings, let's
keep the OsString everywhere.
This also means we need to modify strip_minus_from_mode to make
it work with OsString.
uucore: Move strip_minus_from_mode to mkdir
It's only used there anyway.