Skip to content

nl: allow zero for --join-blank-lines #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

nl: allow zero for --join-blank-lines #8540

merged 1 commit into from
Sep 1, 2025
+22 −15

Conversation

cakebaker
Copy link
Contributor

This PR allows 0 as value for --join-blank-lines to match the behavior of GNU nl:

$ printf "\n\n\n\n\n\n" | nl --join-blank-lines=0 --body-numbering=a
     1
     2
     3
     4
     5
     6

So far we failed with an "invalid number" error.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit a81cf2b into uutils:main Sep 1, 2025
93 checks passed
@cakebaker cakebaker deleted the nl_join_blank_lines_allow_zero branch September 1, 2025 16:34
@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre