pidwait: optimize & cross-platform #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FurryR <[email protected]>
|
Thank you for your contribution, I will start reviewing soon :) |
|
Hm, at least on my machine (using Linux) your changes make the test |
cakebaker
reviewed
Apr 28, 2025
Signed-off-by: FurryR <[email protected]>
Signed-off-by: FurryR <[email protected]>
|
Fixed a bunch of things, now tests can be passed on Output of Requiring further tests on Windows and OpenBSD. |
Signed-off-by: FurryR <[email protected]>
sorry that is my fault. Signed-off-by: FurryR <[email protected]>
cakebaker
reviewed
Jun 1, 2025
cakebaker
reviewed
Jun 1, 2025
cakebaker
reviewed
Jun 1, 2025
Signed-off-by: FurryR <[email protected]> Co-authored-by: Daniel Hofstetter <[email protected]>
|
Sorry for replying late. I am working on it right now. |
Signed-off-by: FurryR <[email protected]>
Signed-off-by: FurryR <[email protected]>
cakebaker
reviewed
Jun 11, 2025
| pub(crate) fn wait( | ||
| procs: &[ProcessInformation], | ||
| timeout: Option<Duration>, | ||
| ) -> Result<Option<()>, std::io::Error> { |
There was a problem hiding this comment.
What's the reason for using Option<()>? Why not use ()?
There was a problem hiding this comment.
I thought that it would be better if we can pass exceptions rather than just unwrap.
There was a problem hiding this comment.
Hm, I don't understand what you mean :| I think we are talking about different things. Maybe my question was too imprecise?
My question is: why do you use Result<Option<()>, std::io::Error> instead of Result<(), std::io::Error> as return type?
There was a problem hiding this comment.
I think using Option<()> is unnecessary because the meaning of this Option is to indicate something there or nothing there, and it's clear that this function doesn't need that meaning; it only needs to know whether an error occurred
cakebaker
reviewed
Jun 11, 2025
| procs: &[ProcessInformation], | ||
| timeout: Option<Duration>, | ||
| ) -> Result<Option<()>, std::io::Error> { | ||
| if !procs.is_empty() { |
There was a problem hiding this comment.
A detail: I would drop the ! and swap the if and else blocks, it's a little bit easier to read.
cakebaker
reviewed
Jun 11, 2025
Co-authored-by: Daniel Hofstetter <[email protected]>
Krysztal112233
requested changes
Jun 18, 2025
| use std::time::Duration; | ||
| use uu_pgrep::process::ProcessInformation; | ||
|
|
||
| pub fn wait(procs: &[ProcessInformation], timeout: Option<Duration>) -> Result<Option<()>> { |
There was a problem hiding this comment.
| use std::time::Duration; | ||
| use uu_pgrep::process::ProcessInformation; | ||
|
|
||
| pub fn wait(procs: &[ProcessInformation], timeout: Option<Duration>) -> Result<Option<()>> { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I noticed that there are some unsafe block in this file, and cloud you please add comments to explain why it's safety here? :)
https://github.com/uutils/coreutils/blob/main/CONTRIBUTING.md#unsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #399 (partially).
Needs to be reviewed before merge as it contains untested code. However it seems that at least the implementation for Linux works fine.