-
Notifications
You must be signed in to change notification settings - Fork 183
[WIP, CI] remove dpctl dependency from onedal/tests/utils/_device_selection.py #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hooray, I have uncovered a seg fault in basicstats on GPU. I am going to disable the pytorch install to see if the sycl runtime is causing problems, then I am going to install dpctl instead to see if it is the runner or the code I wrote in sycl.cpp, and then that would leave only oneDAL as the cause. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Description
Work in progress. Generalize GPU testing to work when dpctl is unavailable, but a SYCL device is.
Depends on #2509
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance