Skip to content

Conversation

KateBlueSky
Copy link

@KateBlueSky KateBlueSky commented Jul 31, 2025

Changes for adding arrayAPI to KMeans.

Added arrayAPI get_namespace and types to the KMeans code. Depends on PR #2640

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@KateBlueSky
Copy link
Author

/intelci: run

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onedal/cluster/kmeans.py 50.00% 5 Missing and 2 partials ⚠️
Flag Coverage Δ
azure 80.64% <52.94%> (-0.07%) ⬇️
github 73.18% <58.82%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/cluster/k_means.py 89.93% <100.00%> (+0.20%) ⬆️
onedal/cluster/kmeans.py 77.67% <50.00%> (-1.30%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KateBlueSky
Copy link
Author

/intelci: run

@KateBlueSky
Copy link
Author

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant