Skip to content

Conversation

sissbruecker
Copy link
Contributor

Description

Removes custom logic for merging I18N values from Flow components with web components defaults. That should now be covered by all web components having support for setting partial I18N objects.

Type of change

  • Refactoring

@Test
public void testFullI18nShouldOverrideCompleteConfigurationInWebComponentProperty() {
Copy link
Contributor Author

@sissbruecker sissbruecker Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were checking that the nested I18N structure was properly merged by the executeJs call that has now been removed. The equivalent would now be to check the internal __effectiveI18n property.

However, since the merging logic is part of the web component, I think it's better to remove this. The web components could use some better test coverage for partial I18n, but that's a separate issue.

Copy link

sonarqubecloud bot commented Sep 9, 2025

@ugur-vaadin
Copy link
Contributor

Should this also change similar logic in AppLayout and MultiSelectComboBox?

@sissbruecker
Copy link
Contributor Author

Should this also change similar logic in AppLayout and MultiSelectComboBox?

Thanks, I missed those. Turns out the partial I18n mechanism was missing for MSCB, so I created a PR for this first: vaadin/web-components#10147

The tests for those components will also need to be changed as they make assertions on the i18n property. I'll have to think about whether ITs are still feasible or if they should be more basic unit tests instead.

@sissbruecker sissbruecker marked this pull request as draft September 9, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants