Add static name to Valkey commands #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Aug 21, 2025
slashmo
force-pushed
the
feature/generate-command-name
branch
from
4abb8de to
7e96dca
Compare
|
You forgot to include the ValkeyCommandsBuilder changes |
Signed-off-by: Moritz Lang <[email protected]>
slashmo
force-pushed
the
feature/generate-command-name
branch
from
7e96dca to
88369d8
Compare
Those changes were already in the PR (https://github.com/valkey-io/valkey-swift/pull/186/files#diff-2f98614f8e9a53691e3637ff419218f0aaf7554d5d9eb48f6572c3087388e002). I did however forget to add the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage ? 40.87%
=======================================
Files ? 84
Lines ? 13852
Branches ? 0
=======================================
Hits ? 5662
Misses ? 8190
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adam-fowler
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most
ValkeyCommandtypes in valley-swift exactly match their underlying Valkey command name. However, for some commands like nested ones the Swift type name differs from the underlying command. This means there's no simple way of accessing the underlying command's name such as using"\(type(of: Self.self))", which is required for Distributed Tracing support to derive proper span operation names based on the command being executed. See Also: #177When running codegen for these commands we do have access to the underlying command names, so we could add them as properties to the generated Swift types.
Note
This PR is split off from #177 to decrease that PR's diff and keep it focused on just adding Distributed Tracing support.
Modifications
Result
All
ValkeyCommandconforming types now have a staticnameproperty exposing the underlying Valkey command name. This will enable proper Distributed Tracing span operation names.