feat(documenten): added operations to bulk upload documents, check th… #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bulk upload status and get a report on the upload
theo-ritense
reviewed
Apr 8, 2025
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/bulk/DocumentImportStatus.kt
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/bulk/CreateImportResult.kt
Show resolved
Hide resolved
zgw/documenten-api/src/test/kotlin/com/ritense/documentenapi/bulk/TestOutboxService.kt
Show resolved
Hide resolved
| @@ -0,0 +1,31 @@ | |||
| package com.ritense.documentenapi.bulk | |||
There was a problem hiding this comment.
If the goal is to use it more often, maybe it should be moved to the test-utils-common module instead?
…this makes usage easier
| @@ -30,5 +30,6 @@ class ResourcePermissionActionProvider : ResourceActionProvider<ResourcePermissi | |||
| var CREATE = Action<ResourcePermission>(Action.CREATE) | |||
| var MODIFY = Action<ResourcePermission>(Action.MODIFY) | |||
| var DELETE = Action<ResourcePermission>(Action.DELETE) | |||
| var IMPORT = Action<ResourcePermission>(Action.DELETE) | |||
| @@ -17,6 +17,7 @@ | |||
| package com.ritense.authorization.request | |||
|
|
|||
| import com.ritense.authorization.Action | |||
| import java.util.* | |||
There was a problem hiding this comment.
Please use individual imports instead of * imports. Pointing it out for this one, but it's in a bunch of files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added operations to bulk upload documents, check the bulk upload status and get a report on the upload
Describe the changes
There is no GitHub issue. I was missing a few endpoints from open-zaak to import bulk documents; see https://open-zaak.readthedocs.io/en/stable/api/experimental.html#id2
I added a few things to make testing of these libs easier.
I have not been able to test it against a running open-zaak as I do not know how I can build Valtimo locally. Maybe someone can help me with that?
Breaking changes
Documentation
Link to the pull request in the Valtimo documentation repository:
New features or changes that have been introduced have been documented.
Tests
Unit tests have been added that cover these changes
Integration tests have been added that cover these changes
Security
The Secure by Default principle has been applied to these changes
Added or changed REST API endpoints have authentication and authorization in place
Valtimo access control checks have been implemented
Dependencies
Newly added dependencies do not introduce known vulnerabilities/CVE's and are in line with the Valtimo license