Skip to content

Conversation

tomerigal
Copy link

@tomerigal tomerigal commented Sep 7, 2025

Background

I was looking to add mediaResolution and found #6256 pull request. It seems to have been inactive for some time, so I've opened this PR that specifically addresses the addition of mediaResolution.

Summary

Pass mediaResolution to google provider options

Manual Verification

Tasks

  • Tests have been added / updated (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • A patch changeset for relevant packages has been added (for bug fixes / features - run pnpm changeset in the project root)
  • Formatting issues have been fixed (run pnpm prettier-fix in the project root)
  • I have reviewed this pull request (self-review)

Future Work

Related Issues

Copy link
Collaborator

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far. Can you please go through the task list in the pull request description? In particular, please add a test and manually verify that the change is working (we usually do that by updating one of the existing examples in examples/ai-core/

@tomerigal
Copy link
Author

tomerigal commented Sep 7, 2025

Changes look good so far. Can you please go through the task list in the pull request description? In particular, please add a test and manually verify that the change is working (we usually do that by updating one of the existing examples in examples/ai-core/

@gr2m a new test has been added, and I've manually verified the functionality.

@gr2m gr2m self-assigned this Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants