Add support for font ligatures via xterm-addon-ligatures - Close #3607 #3853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, which is possible thanks to the xTerm update in #3830, enables support for font ligatures thanks to
xterm-addon-ligatures
.Note that this addon doesn't support the WebGL renderer (from
xterm-addon-webgl
) yet, but that renderer is considered unstable and was disabled during the upgrade to xTerm.js 4 anyway.Hopefully by the time we get to re-enable the WebGL renderer ligatures will be supported on it. I added a comment to warn future maintainers (see line 141 in
lib/components/term.js
).Related issues:
Close #3607